Combined (unexpanded) mode has to go

LOL. Meh, if you can make it work, cool. If not, I’ve still used tt-rss for YEARS so it was high time. :+1:

yeah, this already works on my private branch
just wait a bit, the suffering will be over soon

there’s btw some minor behavior changes: i’ve removed the long standing annoyance i had with how article active state clashed with selected state, so those are now separate; to make sure hotkeys like “u” work as expected active article is considered a honorary member of the selection

my current refactoring efforts in that area involve a metric assload of commented-out horrible code

Ok thanks!

/20 chars

first stage of the great headlines refactoring is here:

https://git.tt-rss.org/fox/tt-rss/commit/e2b8c9273e09091c235959c25d8e4d8122aa6ca8

report all issues itt, i guess

I just updated via git.

Left clicking on the title marks the article read. Earlier it opened the article’s url.
Now I have to “ctrl+left click” if I want to visit the original website.

Not sure if it is an intended behaviuor

combined or normal mode?

e: combined, right, gonna fix this in the next changeset

pull

It’s working now.
Thanks

alright guys

https://git.tt-rss.org/fox/tt-rss/commit/5aa9c604943cbb93f4d401914dafeedfddb0007e

report all issues, etc

it’s really sad how i can’t ever remove anything

We love you @fox!!! :crazy_face:

I was afraid this was going to ruin my experience. I made a note of the last commit before all this went down. Then I did a git pull, clicked Reload in my browser, and prepared myself for the worst.

And absolutely nothing changed.

So I have a feeling I wasn’t using this feature and I won’t miss it.

:smiley:

either that or you managed to update after it was re-added back :slight_smile:

How do I enable it? In prefs I only see “Combined feed display”, but no option to disable expanded view. Am I missing something?

f c toggles between expanded/unexpanded

Working now, thanks for bringing this back!

https://discourse.tt-rss.org/t/combined-unexpanded-mode-has-to-go/1668/41

I am running 78780c9c08cde4b7e7ee44efa29fa5c19a918040
Now clicking on link inside post does nothing, except marking the article read.
Ctrl+click does not work.

At the moment I can only right click on the link, copy the url and pasting it in a different tab.

I am using Chrome 70.0.3538.110

Tried to refresh, log out and back in, but it does not change behaviour.

yeah it’s a small bug, should be fixed in trunk now

Yep. It’s back to normal now.
Thanks

At present on on commit b572295 . Using in chromium-browser, incognito mode and other browsers as well, now the following issue…

Previously, right-clicking on an article headline, then clicking ‘Open Original Article’ in the context menu would open the article in a new browser tab and mark the clicked article ‘read’.

This isn’t happening anymore (the marking ‘read’ part). Usually configured in Preferences as ‘Combined feed display’, but now regardless of config, articles are not being mark ‘read’ when right-clicking, etc. as described above.

Is this intended?
.

i’ll take a look when i’m done with current stuff, thanks for reporting

e: fixed on staging branch

Now, when selecting a new feed or category the first article is automatically selected and thus marked-as-read.
Can this be fixed ?
Thanks.