Just for note: some fields, such as author, are updated for already imported items. And even filters are started again for these items (as a consequence: if user removes some labels and thereafter some filter assigns some removed labels then deleted labels are repaired).
I had noticed that some time ago and put the comments count update into the date_updated modification branch so that no new hash calculation would be triggered, like so:
--- a/include/rssfuncs.php
+++ b/include/rssfuncs.php
@@ -757,7 +757,7 @@
$base_entry_id = db_fetch_result($result, 0, "id");
- db_query("UPDATE ttrss_entries SET date_updated = NOW()
+ db_query("UPDATE ttrss_entries SET date_updated = NOW(), num_comments = '$num_comments'
WHERE id = '$base_entry_id'");
continue;
(Yeah, I’m somewhat behind latest trunk. Line should be here now).
While hijacking this conversation I could also mention that the possibility of content replacement for starred articles is not really satisfactory. This can be fixed with
- if ($entry_current_hash == $entry_stored_hash && !isset($_REQUEST["force_rehash"])) {
+ if ($marked_ || ($entry_current_hash == $entry_stored_hash && !isset($_REQUEST["force_rehash"]))) {
here, where $marked_ indicates if the entry is starred or not and has to be set somewhat above that change. Dunno how anybody else feels about this, but I lost some starred articles because of hash recalculations.
Is there a chance this could be made optional? I don’t speak PHP, or I’d attempt it myself. I was wondering if there could be a checkbox on the feed preferences, and then if true, the comment count could be checked. If false, it would be excluded from the hashing.
There are some sites where I like what the authors say, but the comments sections are less than spectacular, where less than spectacular refers to dumpster fires.
I’d like to be able to keep up with what the author says, but don’t need the updates whenever someone comments on the article.
are you sure you actually understand what was discussed here?
hint: you are not going to get duplicate articles or whatever, it’s just the comment count will change in the UI, if you read the article already you will never notice this.