Unhandled exception when sorting feeds

Hello, I think this bug is just a small thing, but I rather report it.

After I drag and drop feed to category on Feeds in /prefs.php and I want to drag another I get this error:

Unhandled exception
Error: assertion failed in ItemFileWriteStore

Error: assertion failed in ItemFileWriteStore
    at Object._assert (https://domain:8080/lib/dojo/tt-rss-layer.js?1485331582:8:16676)
    at Object._setValueOrValues (https://domain:8080/lib/dojo/tt-rss-layer.js?1485331582:8:20649)
    at Object.setValues (https://domain:8080/lib/dojo/tt-rss-layer.js?1485331582:8:20469)
    at https://domain:8080/lib/dojo/tt-rss-layer.js?1485331582:8:407667
    at Object.forEach (https://domain:8080/lib/dojo/dojo.js?1485331582:8:35522)
    at Object.pasteItem (https://domain:8080/lib/dojo/tt-rss-layer.js?1485331582:8:407494)
    at Object.<anonymous> (https://domain:8080/lib/dojo/tt-rss-layer.js?1485331582:8:421640)
    at Object.forEach (https://domain:8080/lib/dojo/dojo.js?1485331582:8:35477)
    at Object.onDndDrop (https://domain:8080/lib/dojo/tt-rss-layer.js?1485331582:8:421371)
    at Object._19f (https://domain:8080/lib/dojo/dojo.js?1485331582:8:41980)

Same error is logged in TTRSS system log

This is content Chrome console:

image

So I’m completely fine move first item, error appear after first move if I try move another, or if I select category (click on checkbox icon)
If I refresh page, I can again move one item before error.

Steps to reproduce the problem:
Open /prefs.php move feed between category and try move another.

tt-rss version :
Tiny Tiny RSS v17.12 (c9a5e5a) (maybe 14 day old)
and Tiny Tiny RSS v17.12 (16325f7) (today 15.3.18)
Ubuntu server 16.04
Ubuntu 16.04 PHP 7,PostgreSQL

I was able to reproduce it on Chrome and Firefox on Windows
Thanks :slight_smile:

that’s, uh, interesting. just a few remarks

  1. the error seems to be raised within dojo code (ItemFileWriteStore is a part of it)
  2. i can’t reproduce it :frowning:

it could be related to something like special symbols in feed titles but i think it’s unlikely. i wonder what that assertion actually checks for, it would be hard to find in minified code.

Hello fox

hmm
Some special character is possible, I have all sort of garbage in feeds name.

For example, this is my longest feed name:
"Recent posts to When upgrading I see a lot of messages "N: Ignoring file '20auto-upgrades.ucf-old' in directory '/etc/apt/apt.conf.d/' as it has an invalid filename extension""

I also tried remove all # and * from feed name but it did not help
Fortunately, this is not really a major problem

btw you can try making a separate account and see if the issue persists without your feeds (and possibly with them)

Thanks!

I crate separate account and tred sorting fieed - no problem

But after that I tried export OPML from new test account (test account has 2 feeds).

I get this error:
(same error for all accounts)

ReferenceError: tmp is not defined
at gotoExportOpml (https://domain:8080/prefs.php:340:47)
at Object.eval [as onClick] (eval at construct (https://domain:8080/lib/dojo/tt-rss-layer.js?1485331582:8:8026), :2:1)
at Object._onClick (https://domain:8080/lib/dojo/tt-rss-layer.js?1485331582:8:210001)
at HTMLInputElement. (https://domain:8080/lib/dojo/dojo.js?1485331582:8:32910)
at Object.__onClick (https://domain:8080/lib/dojo/tt-rss-layer.js?1485331582:8:209876)
at HTMLSpanElement. (https://domain:8080/lib/dojo/dojo.js?1485331582:8:32910)

and Chrome console:

This is very strange, I checked my phpinfo and I’d rather change “sys_temp_dir” from default “no value” to /tmp - but no change

But it means that the problem will not be in the feed name…mabye :slight_smile:

gotoExportOpml

that’s likely related to js strict mode

e: fix https://git.tt-rss.org/fox/tt-rss/commit/d195c6a62e4967682c42397c53d100b5e5412c0a

Thanks

After update exporting is now fixed

Clean test account is without problem.
I exported feeds from my main account and imported them in new test account…
And same error (assertion failed in ItemFileWriteStore)

So cause is something in my feed list.

I did some testing on test account:

  • When I unsubscribe from all feeds and (and left my categories unchanged) then I add single feed and try two move - same error.
    If I delete my old categories - no error.
    The strange thing is that I can do two moves before error. Before unsubscribing I can do only one move before error.

  • When I delete all categories, feed are moved to uncategorized folder, then I create category and try couple of moves - same error

So I can not find common cause because it does not behave consistently (I have to delete categories and feeds to not get error)
Maybe some “limit” ? I have 781 feeds and three levels of categories.

But maybe I spent more time on it than problem deserve

it’s really hard to answer because this is entirely dojo code :frowning:

could even be the overall structure i.e. nesting, if you have it
could be category titles

btw check for server-side errors in tt-rss event log, maybe actual tt-rss code which is called when drag and drop is complete is failing and somehow causes this