Tiny Tiny RSS: Community

Strict mode javascript in tt-rss


#1

I’m planning to enable JS strict mode for core tt-rss code soon.

Some minor code-correctness related issues may popup here and there but it shouldn’t be a transition as drastic as PDO was.

If anyone wants to help with testing development branch is available here: https://git.tt-rss.org/fox/tt-rss/src/js-strict-mode


#2

There might be something odd with combined display mode (at least):

  1. Use combined display mode
  2. Click an unread row to view the contents
  3. Note the row doesn’t appear to get marked as read (or not unread), although the counters update, AJAX requests are sent, and a refresh shows the expected “read” state

I’m currently on the latest js-strict-mode ( https://git.tt-rss.org/fox/tt-rss/commit/a72643257afa150e128513d8663690c049229983 ), and things work as expected on master. I can do some more digging later on.


#3

that’s strange. which browser is it? it works fine for me on chrome.

what if you press u does it get un/marked?


#4

I’m using Firefox 58.0.2 on multiple machines, Ctrl+F5’ing to clear the cache. I’ll try Chrome later.

If I expand an article, press “u”, and collapse the article it shows up as read. Otherwise there’s no indication aside from the counter changing.

Strangely, if I expand the first row and press “u” it shows up as read when both expanded and collapsed.

Also, I’ve sent over https://git.tt-rss.org/fox/tt-rss/pulls/50 to fix helpDialog.


#5

if its specific to firefox reporting to mozilla to fix anything is likely to be useless. also marking stuff is basically DOM manipulation which has nothing to do with js strict mode. strange.

i’ll install firefox after weekend and take a look


#6

Been running both side-by-side for a day or so, and no obvious (related) issues noticed so far. (Firefox 58, Ubuntu 17.10, mysql 14.14, php 5.5.38.)


The only thing I’ve noticed is the lack of feed icons on the strict version, but I’m blaming that on lack of cached images on the strict version due to them sharing the same database (I know, I know…)


#7

I’ve created https://git.tt-rss.org/fox/tt-rss/pulls/51 that corrects the read/unread issue, as well as a number of dialog variables.


#8

thanks, merged in the PR


#9

UPD: this branch is now merged in trunk


Toggle Widescreen: ReferenceError: assignment to undeclared variable article_id (after updating to strict-mode js)