Just did a git up and so far it just worked™: no errors, no update screen, no issues updating feeds, no problems. If I was not reading this thread, I would not have noticed any changes whatsoever – well, apart from lots of git commit messages and files changed.
i dunno, nothing changed with regard to hashes, it’s an entirely client thing (it’s a thing after # in page url) and has nothing to do with PDO changeover. the whole function happens in your browser.
Mark’s issue is related to the perceptual hash plugin. if you are using it you need to update to latest revision which uses PDO and check if plugin schema is initialized.
Overall behavior change here is stricter error checking in general and specifically during feed updates which are now per-article transaction-locked. So for example plugin is unlikely to fail silently while feed is updated.
everything works except login:
PHP message: PHP Fatal error: Uncaught Error: Call to a member function check_password() on null in /tt-rss/classes/pref/prefs.php:925
Stack trace: #0 /tt-rss/include/functions.php(1091): Pref_Prefs::isdefaultpassword() #1 /tt-rss/classes/rpc.php(327): make_init_params() #2 /tt-rss/backend.php(123): RPC->sanityCheck() #3 {main}
thrown in /tt-rss/classes/pref/prefs.php on line 925
[error] 26432#0: *1515 FastCGI sent in stderr: “PHP message: PHP Parse error: syntax error, unexpected ‘$authenticator’ (T_VARIABLE) in /var/www/ttrss/classes/pref/prefs.php on line 925”
Ah-ha. The single user commit is actually after the one I reset back to. But I may not have reset it properly. I just did a reset --hard and now ttrss has loaded succesfully. So yes it’s one of those latest commits doing it.
Also (not hijacking other thread) in regards to the fever API plugin. It is broken, but I expected that. Hopefully someone can fix it one day but I just won’t use it for the moment.
"PHP message: PHP Notice: Legacy connect requested to pgsql in /var/www/ttrss/classes/db.php on line 22
PHP message: PHP Fatal error: Uncaught Error: Call to a member function query() on null in /var/www/ttrss/plugins.local/repos/fever/fever/fever_api.php:149
well the PR fix has been submitted so i guess this should work now
re: fever plugin and maybe others like it
i guess there’s a change that legacy database connection is not initialized automatically for the plugins now. regardless, this should be a very easy one line fix. somewhere in init() there should be first mention of $this->dbh or something like that, just put $this->dbh = Db::get() before it and it should work.