Tiny Tiny RSS: Community

Mailer.php digest email "from address" is set to the "to address"


#1

Describe the problem you’re having:

The digest email “from address” is set to the “to address”.

tt-rss version (including git commit id):

v18.12 (986ca25)

Platform (i.e. Linux distro, PHP, PostgreSQL, etc) versions:

Linux, Debian stable

Please provide any additional information below:

I see in https://git.tt-rss.org/fox/tt-rss/src/master/classes/mailer.php#L19 that it currently reads:

$from_combined = $from_name ? "$to_name <$to_address>" : $to_address;

Is that intentional or a copy/paste that wasn’t updated after?

I thought I’d ask because since upgrading to 18.12 Gmail complains about my digest emails being sent from $to_address.

Cheers, Ian


#2

yeah, it’s very likely a typo.
e: https://git.tt-rss.org/fox/tt-rss/commit/eb48aa5840aff2ed7ab6b2f7b6e27abe8508234a


#3

Updated here - many thanks for the swift answer and resolution. I will now delete the PHPMailer plugin I installed earlier…

Cheers, Ian