Impending doom part 2: Objects

[fox]

Heads up: substantial javascript changes are going to be merged into master soon, those are currently staging in js-objects branch on gogs:

https://git.tt-rss.org/fox/tt-rss/src/js-objects

As usual, report all issues itt. If you want to play around with things and maybe find bugs before this pile of, uh, code hits master, check the branch out.

[fox]

Heads up, master merge of js-objects is imminent. Report all issues ITT.

here we go.gif

[martywd]

Now at commit 3318555
Re: my complaint in thread… (Combined (unexpanded) mode has to go)

@martywd

At present on on commit b572295 . Using in chromium-browser, incognito mode and other browsers as well, now the following issue…

Previously, right-clicking on an article headline, then clicking ‘Open Original Article’ in the context menu would open the article in a new browser tab and mark the clicked article ‘read’.

This isn’t happening anymore (the marking ‘read’ part). Usually configured in Preferences as ‘Combined feed display’, but now regardless of config, articles are not being mark ‘read’ when right-clicking, etc. as described above.

Is this intended?

.

Again, with ‘Combined feed display’ ticked in Preferences. Now right-clicking…, then clicking ‘Open Original Article’ in the context menu does in fact mark the article read and then open the article at the linked website in a new browser tab as expected. … But. … The right-clicked article contents back in the tt-rss pane ALSO is opened. Not expected.

FWIW, disabling ‘Combined feed display’ in Preferences does yield the expected behavior of right-click…, Open Original… which opens the article in a new tab and marks the article in tt-rss read without expanding the article’s contents in tt-rss. Expected behavior.

Can this be fixed to get the same expected behavior when ‘Combined feed display’ is enabled?

.

[fox]

@martywd

Can this be fixed to get the same expected behavior when ‘Combined feed display’ is enabled?

i think this should make it work as expected:

https://git.tt-rss.org/fox/tt-rss/commit/6d3092c7427c690aa6c517e79f4c39b27bfc00f0

[martywd]

@fox

i think this should make it work as expected:

Yup, that fix this issue (now at commit 9672ddf). Thanks very much @fox !
.

[martywd]

Now at commit c700345

The issue:
Right-click on any article in any feed, click on ‘Toggle unread’ in context menu to mark the article unread or read depending on the article’s present state. At the bottom of the browser a ‘Loading, please wait’ bar appears and does not disappear as expected although the article has already been successfully marked unread / read.

The ‘Loading, please wait…’ bar remains visible until one clicks some where else in tt-rss. This also happens using keyboard shortcuts to select article, then mark read/unread.

Right-clicking on a feed in the Categories pane, click ‘Mark as read’ and the ‘Loading, please wait…’ bar appears momentarily and then goes away as expected.

Is no one else seeing this behavior?

.

[fox]

the underlying change here is that progress notifications don’t auto-hide anymore which is why a few got stuck like this (since they are not closed when the operation is complete)

i’m going to remove this particular loading… prompt but if you find any more please also report them.

https://git.tt-rss.org/fox/tt-rss/commit/f33cd597be3f56b67eb23b42ae756b3c1397bf8a