I’d like you to make some changes in get_version function (include\functions.php) to support non-docker Windows host.
I tested some of your code on my config (Windows 10 x64, latest git pull origin master):
1.
if (‘\’ === DIRECTORY_SEPARATOR) { $ttrss_version[‘version’] = “UNKNOWN (Unsupported, Windows)”;
This condition is always true so It will not check version but write “UNKNOWN” right away.
2.
In
exec('git…
you use php function escapeshellarg which has different meaning on Windows:
On Windows, escapeshellarg() instead replaces percent signs, exclamation marks (delayed variable substitution) and double quotes with spaces and adds double quotes around the string.
(from php manual)
So to make get_version working on my windows machine I had to remove DIRECTORY_SEPARATOR check and replace escapeshellarg with double quotes
.‘“version: %ct %h”’.
I hope this will help you to make changes in your repository.
If you’d consider a PR, I’ll file it. I’m one of those stupid bastards running unsupported on Windows (and have for nearly 10 years). It doesn’t look like it would mess much up but won’t waste our times if you are not interested.
