Auth_remote plugin broken by recent commit

Tiny Tiny RSS Support
1

auth_remote broken by typo in plugins/auth_remote/init.php line 48 has $try_login = $_SERVER["hdr"]; when it should be $try_login = $_SERVER[$hdr];

2

oops, my bad. sorry.

https://git.tt-rss.org/fox/tt-rss/commit/dc40f695119996c0ce7f479eb0903f0994408800

3

I have Apache doing HTTP Auth in front of tt-rss.

I still had a problem with this because the REMOTE_USER header was set, but empty. My real username is carried in the HTTP_REMOTE_USER header instead.

I changed line 47 from this:

if (isset($_SERVER[$hdr])) {

to this:
if (!empty($_SERVER[$hdr])) {

…and now it works again. I’m unsure if this is a good fix, but it works for me!

4

ok, i’ll replace isset with empty. thanks for reporting.

https://git.tt-rss.org/fox/tt-rss/commit/0868ff9d6495151a7cc25db541915943aefcd740